Workaround 20.04 FindBoost issue #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jerry-GeGarcia
approved these changes
Dec 20, 2022
JeffMill
reviewed
Dec 22, 2022
| # (Enable --trace-expand in cmake and look at lines from boost_headers-config.cmake and its callers.) | ||
| # Workaround: force cmake to look in "/usr" since the /lib and /bin paths are either | ||
| # not relevant for our usage or they are symlinks to /usr/lib and /usr/bin. | ||
| set(CMAKE_PREFIX_PATH "/usr") |
There was a problem hiding this comment.
are we okay just always using /usr/* ? is there ever a case where we'd want to search /lib or /bin ?
There was a problem hiding this comment.
Build is successful on all of the platforms we target today. We will definitely revisit if it breaks somewhere.
shishirb-MSFT
added a commit
that referenced
this pull request
Mar 23, 2023
* A prior PR (#145) fixed the issue when building DO itself. However, consumers of DO still face the issue because DO's cmake config file was not updated. This is now fixed. * DO's own CMakeLists.txt checks for /lib being a symlink before updating CMAKE_PREFIX_PATH (update to fix in #145). * Also enable exec permission for the sdk cleanup install script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.